bug returned in 4.957c: annotations for assignments lost when controller is not available

[ThomasAH]

Hi Pete!

I just wanted to report the duplicate annotations problem with user comments and saw that you already fixed this in 4.957c:

Quote

More consistently removes previous auto INI annotations before generating new ones

I can confirm that this problem is now fixed, but with this change, the bug you already have fixed in 4.954b returned: Annotations for disconnected devices are removed again.

With 4.957b this problem does not occur, but of course annotations are duplicated when comments are used.

See this thread for the original bug report.

[Pete Dowson]

On 10/7/2016 at 1:46 PM, ThomasAH said:

with this change, the bug you already have fixed in 4.954b returned: Annotations for disconnected devices are removed again.

Hmm. That may not be easy to fix, because the detection of missing joysticks is much later than the deletion of the existing annotations, and because the joystick is missing the entries aren't processed to add to the look-up tabled. Without the processing no new annotation is generated.

I'll have a look at this once I've aught up with the support backlog.

Pete

 

 

[Pete Dowson]

Okay. I think it only applied to button assignments, not axes, and it was easier to fix than I thought. Try this pre-release:

FSUIPC4957e.zip

Pete

 

[ThomasAH]

4.957e works fine, all comments and annotations are preserved or updated, nothing is duplicated.

Thank you again!

[ThomasAH]

I just noticed that it is not completely fixed, the comments and annotations are preserved, but the distance between them grows:

10=P64,5,Cx06000D0C,x0080 ; Taxi Light  -{offset word setbits, offset 0D0C}-
12=P64,6,Cx0A000D0C,x0080 ; Taxi Light  -{offset word clrbits, offset 0D0C}-
13=P64,7,Cx06000D0C,x0220 ; Panel+Cabin Light   -{offset word setbits, offset 0D0C}-
14=P64,8,Cx0A000D0C,x0220 ; Panep+Cabin Light   -{offset word clrbits, offset 0D0C}-

(with a tab between comment and annotation) becomes

10=P64,5,Cx06000D0C,x0080 ; Taxi Light          -{offset word setbits, offset 0D0C}-
12=P64,6,Cx0A000D0C,x0080 ; Taxi Light          -{offset word clrbits, offset 0D0C}-
13=P64,7,Cx06000D0C,x0220 ; Panel+Cabin Light           -{offset word setbits, offset 0D0C}-
14=P64,8,Cx0A000D0C,x0220 ; Panep+Cabin Light           -{offset word clrbits, offset 0D0C}-

(with tab-space-tab between comment and annotation) becomes

10=P64,5,Cx06000D0C,x0080 ; Taxi Light                  -{offset word setbits, offset 0D0C}-
12=P64,6,Cx0A000D0C,x0080 ; Taxi Light                  -{offset word clrbits, offset 0D0C}-
13=P64,7,Cx06000D0C,x0220 ; Panel+Cabin Light                   -{offset word setbits, offset 0D0C}-
14=P64,8,Cx0A000D0C,x0220 ; Panep+Cabin Light                   -{offset word clrbits, offset 0D0C}-

(with tab-space-tab-space-tab between comment and annotation).

[Pete Dowson]

Okay. Evidently, when deleting in preparation for adding afresh, I'm not deleting the previous Tab. I'll fix it in the next release. I'll remove all tabs beforehand before inserting the new tab+text, so it will revert to the way it should be!

Thanks,

Pete

 

[ThomasAH]

Sounds good, thank you!

Edit: Fix confirmed for 4.958