FSUIPC6 & FSUIPCClient return wrong values

[Frédéric-O DUCHEMIN]

Hello Paul,

Since I have switched to FSUIPC V6.0.3 (payware) but not the Sim (Prepar3D® v4, Version: 4.5.13.32097) H2

FSUIPCConnection.FSUIPCVersion.ToString()

Return FSUIPC V6.00000

@Paul Henty @John Dowson

 ' check fsuipc version
            Dim literal As String = FSUIPCConnection.FSUIPCVersion.ToString()
            Console.WriteLine(literal.ToString)
            Dim substring As String = literal.Substring(0, 1)
            'MessageBox.Show("FSUIPC V: {0}", substring)
            Console.WriteLine("FSUIPC V: {0}", substring)
            Dim version As String = Webrequesttoget(If(My.Settings.VaWebSite & "/fsuipc_version_v2.php?version=" & substring, ""))
            If Operators.CompareString(version, literal, False) > 0 Then
                Me.RadDesktopAlert1.Popup.Image = SDA.My.Resources.Resources.In_Progress_48px
                'Me.RadDesktopAlert1.ContentImage = SDA.My.Resources.Resources.In_Progress_48px
                'Me.radDesktopAlert1.CaptionText = "New E-mail Notification"
                Me.RadDesktopAlert1.ContentText = "New version of FSUIPC is released. Update FSUIPC to " & version
                Me.RadDesktopAlert1.Show()
                If MsgBox("New version of FSUIPC is released. Update FSUIPC to " & version, MsgBoxStyle.OkCancel Or MsgBoxStyle.Question, "Warning") = MsgBoxResult.Cancel Then
                    Return
                End If
                If Conversions.ToDouble(substring) = 4.0 Then
                    Process.Start("http://fsuipc.simflight.com/beta/FSUIPC4.zip")
                End If
                If Conversions.ToDouble(substring) = 5.0 Then
                    Process.Start("http://fsuipc.simflight.com/beta/FSUIPC5.zip")
                End If
                If Conversions.ToDouble(substring) = 6.0 Then
                    Process.Start("http://fsuipc.simflight.com/beta/FSUIPC6.zip")
                End If
            End If
        Catch ex As Exception

********* FSUIPC6, Version 6.0.3 (18th April 2020) by Pete & John Dowson *********
Prepar3D.exe version = 4.5.13.32097
Running inside Prepar3D v4
Module base=7FFFB7FD0000
Windows 10 Pro 64 Bit reported as Build 18363, Release ID: 1909 (OS 10.0)
Reading options from "D:\P3DV4\Modules\FSUIPC6.ini"
Checking the Registrations now ...
FSUIPC6 Key is provided
WideFS7 Key is provided

Running in "Lockheed Martin® Prepar3D® v4", Version: 4.5.13.32097 (SimConnect: 4.5.0.0)

FSUIPC6.ini

[General]
UpdatedByVersion=6003

There are something wrong?

Fred

[Paul Henty]

Hi Fred,

 

Return FSUIPC V6.00000

Is that from this line?

Console.WriteLine(literal.ToString)

The ToString() function is formatted to 3 decimals, so I can't see how you can get 6.00000.

Can you please check the values of:

FSUIPCConnection.FSUIPCVersion.Major
FSUIPCConnection.FSUIPCVersion.Minor
FSUIPCConnection.FSUIPCVersion.Build

 

Or is it from this line?

Console.WriteLine("FSUIPC V: {0}", substring)

Your 'substring' variable only contains the major version.

Paul

[Frédéric-O DUCHEMIN]

Hi Paul,

In FrMain with FSUIPC V5.X no problem I don't have change the code
Now with FSUIPC V6.0.X I see 6.000

Value of literal of course not substring The app return the good value with the function

I think it's in your dll

FSUIPCConnection.FSUIPCVersion.Minor
FSUIPCConnection.FSUIPCVersion.Build

 

But I make a quick test again

Fred

 

[Paul Henty]

FSUIPCConnection.FSUIPCVersion.Minor

is returning 3?

Paul

[Frédéric-O DUCHEMIN]

4 minutes ago, Paul Henty said:

FSUIPCConnection.FSUIPCVersion.Minor

is returning 3?

Paul

Nope it's the web response

For your test

Console.WriteLine(String.Format("Major {0} (Minor {1}, Number {2})", FSUIPCConnection.FSUIPCVersion.Major.ToString, FSUIPCConnection.FSUIPCVersion.Minor.ToString, FSUIPCConnection.FSUIPCVersion.Number.ToString))

Major 6 (Minor 0, Number 6)

 

[Paul Henty]

Okay - thanks for the tests.

It looks like FSUIPC6 is not giving the correct minor and build version from offset 0x3304.

@John Dowson Can you look into this please?

Paul

[John Dowson]

 Think there is maybe a discrepancy as the IPC version number is 6003 (maybe should be 6030). With the FSUIPC6 release, I am trying to change the visible version number to the format <major>.<minor>.<patch><addedLetter for internal release>, but keep the internal numbers as they are. The patch level uses the last two digits so that I can go above 9 in the visible version. Maybe I've specified this incorrectly, I'll check sometime next week.

John

P.S. Major should be 6, minor 0, and patch/number should be 3 (with latest release). Will check the offsets later.

[John Dowson]

Just checked and I forgot to update version for IPC in the header. I will correct this in the next release.

[Frédéric-O DUCHEMIN]

Hello,

Thanks  for your times  @John Dowson & @Paul Henty

I can use this version 6.03d or you don't have make changes ?

Result:

********* FSUIPC6, Version 6.0.3d (18th April 2020) by Pete & John Dowson *********

Prepar3D.exe version = 4.5.13.32097

Running inside Prepar3D v4

Module base=7FFC445C0000

Windows 10 Pro 64 Bit reported as Build 18363, Release ID: 1909 (OS 10.0)

Reading options from "D:\P3DV4\Modules\FSUIPC6.ini"

Regards Fred